Fixing Issue with text classes from TW 5#251
Open
mo-fouad wants to merge 1 commit intonativewind:mainfrom
Open
Fixing Issue with text classes from TW 5#251mo-fouad wants to merge 1 commit intonativewind:mainfrom
mo-fouad wants to merge 1 commit intonativewind:mainfrom
Conversation
When using Variants with text-centre, text-left, or text-right, we have a Bug as it shows here nativewind#232
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug with Tailwind CSS text alignment classes (text-center, text-left, text-right) when used with variants in TextInput components. The issue was caused by an incorrect mapping configuration for the textAlign property.
Key Changes:
- Updated the
textAlignmapping in TextInput's style configuration from a boolean value to a string literal mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Variants with text-centre, text-left, or text-right, we have a Bug as it shows here